labelFontSize is ignored

[aprzywecki@…]

The option 'labelFontSize' is ignored because it's not used in _renderAxisLabel() in chart.py. Adding:

cx.set_font_size(self.options.axis.labelFontSize)

to _renderAxisLabel() in chart.py fixes the problem.

Adam

[lgs]

Thanks for reporting this. It is fixed now in [138]

[ged@…]

The problem is still present for pie charts since that code doesn't use _renderAxisLabel.

[lgs]

Pie charts do not have an axis label. That's why they don't use that code.

[ged@…]

Well, I didn't mean that code should be called. I just pointed out why pie charts didn't respect that setting. Now as for the question as whether they should respect that setting, it all depends what you consider as axes: in a pie chart, you obviously don't have vertical and horizontal axes, but the different labels on the sides could be considered as labels next to a round axis. At least that prevents to have to add another setting just for pie charts, which will probably be configured to the same value as the labelFontSize anyway. If you don't agree pie charts should use the same setting as for other charts, I will create a separate enhancement ticket.

[lgs]

Let me explain it better: the labelFontSize option is related to the axis label, not the axis ticks. You have several different texts drawn in a chart:

• Chart title
• Legend text
• Axis labels (axis titles)
• Axis ticks (probably what you want)
• Yvals above bars (probably same size as axis ticks)

So far there is no option to change the size of axis ticks and you don't want to draw the ticks with the same size as the axis title, don't you?

[ged@…]

Oh. Sorry for the confusion and thanks for the clarification. Well, in that case I'll create an enhancement ticket for the font size of the axis ticks, including those of the pie chart.

[lgs]

No problem at all. I'm happy to get more feedback :-)